fix(busted) - before_each and after_each execute in unpredictable order - fixes #491 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table order. Just changed the tables that store these functions to be indexed by the parent `describe`s index in the current_describe table which uses sequential integers. Then in the run_each function where these functions get executed, iterating thru them usning ipairs instead of pairs.
stringTrimmer
changed the title
|
Great! Could we get this merged soon? |
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #491 ; Encountered the same problem as @OscarCreator.
Just changed the tables that store the before_each and after_each functions to be indexed by the parent
describes index in the current_describe table which uses sequential integers. Then in the run_each function where these functions get executed, iterating thru them usning ipairs instead of pairs. That seems to put things in the order I'd expect.Of course if you run the tests using the old code, they might be successful occasionally (it's up to however lua decides to store/iterate the table keys each time). But using the changes, the tests should succeed every time.